Hi,
On Sat, Oct 31, 2020 at 1:22 PM Sergio Paracuellos
<sergio.paracuellos@xxxxxxxxx> wrote:
>
> This series adds support for the PCIe PHY found in the Mediatek
> MT7621 SoC.
>
> This is the first attempt to get feedback of what is missing in
> this driver to be promoted from staging.
>
> There is also a 'mt7621-pci' driver which is the controller part
> which is still in staging and is a client of this phy.
>
> Both drivers have been tested together in a gnubee1 board.
>
> This series are rebased on the top of linux-next:
> commit 4e78c578cb98 ("Add linux-next specific files for 20201030")
>
> Changes in v4:
> - Bindings moved from txt to yaml so previous Rob's Reviewed-by
> is not in the new patch with the yaml file.
> - 'phy-cells' property means now if phy is dual-ported.
> - Avoid custom 'xlate' function and properly set registers
> when the phy is dual ported.
> - Add use of 'builtin_platform_driver'.
> - Added a patch including myself as maintainer in the
> MAINTAINERS file.
> - Add a patch removing patch from staging to make easier
> the complete inclusion and avoid possible problems might
> appear in 'linux-next' if the series are included.
Kishon, Vinod, any comments on this? Is here something wrong or
missing in order to get this accepted through your tree?
Thanks in advance for your time.
Best regards,
Sergio Paracuellos
>
> Changes in v3:
> - Recollect Rob's Reviewed-by of bindings.
> - Make Kishon Vijay suggested changes in v2:
> (See https://lkml.org/lkml/2019/4/17/53)
> - Kconfig:
> * Add depends on COMPILE_TEST
> * Select REGMAP_MMIO
> - Make use of 'soc_device_attribute' and 'soc_device_match'
> - Use regmap mmio API instead of directly 'readl' and 'writel'.
> - Use 'platform_get_resource' instead of 'of_address_to_resource'.
>
> Changes in v2:
> - Reorder patches to get bindings first in the series.
> - Don't use child nodes in the device tree. Use #phy-cells=1 instead.
> - Update driver code with new 'xlate' function for the new device tree.
> - Minor changes in driver's macros changing some spaces to tabs.
>
> Thanks in advance for your time.
>
> Best regards,
> Sergio Paracuellos
>
> Sergio Paracuellos (4):
> dt-bindings: phy: Add binding for Mediatek MT7621 PCIe PHY
> phy: ralink: Add PHY driver for MT7621 PCIe PHY
> MAINTAINERS: add MT7621 PHY PCI maintainer
> staging: mt7621-pci-phy: remove driver from staging
>
> .../devicetree/bindings/phy}/mediatek,mt7621-pci-phy.yaml | 0
> MAINTAINERS | 6 ++++++
> drivers/phy/ralink/Kconfig | 8 ++++++++
> drivers/phy/ralink/Makefile | 1 +
> .../pci-mt7621-phy.c => phy/ralink/phy-mt7621-pci.c} | 0
> drivers/staging/Kconfig | 2 --
> drivers/staging/Makefile | 1 -
> drivers/staging/mt7621-pci-phy/Kconfig | 8 --------
> drivers/staging/mt7621-pci-phy/Makefile | 2 --
> drivers/staging/mt7621-pci-phy/TODO | 4 ----
> 10 files changed, 15 insertions(+), 17 deletions(-)
> rename {drivers/staging/mt7621-pci-phy => Documentation/devicetree/bindings/phy}/mediatek,mt7621-pci-phy.yaml (100%)
> rename drivers/{staging/mt7621-pci-phy/pci-mt7621-phy.c => phy/ralink/phy-mt7621-pci.c} (100%)
> delete mode 100644 drivers/staging/mt7621-pci-phy/Kconfig
> delete mode 100644 drivers/staging/mt7621-pci-phy/Makefile
> delete mode 100644 drivers/staging/mt7621-pci-phy/TODO
>
> --
> 2.25.1
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
