Re: [PATCH v2 3/3] staging: brcm80211: replaced WL_ERROR with dev_err in two files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-04-07 at 12:29 +0200, Roland Vossen wrote:
> Code cleanup. Use Linux functions instead of Broadcom specific
> one. On spots where the device object is not yet available,
> pr_err() is used instead.
> 
> Signed-off-by: Roland Vossen <rvossen@xxxxxxxxxxxx>
> Reviewed-by: Arend van Spriel <arend@xxxxxxxxxxxx>
> ---
>  drivers/staging/brcm80211/brcmsmac/wl_mac80211.c |  231 ++++++++++++----------
[]
> @@ -216,7 +218,8 @@ wl_ops_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
>  	WL_UNLOCK(wl);
>  
>  	if (err != 0) {
> -		WL_ERROR("%s: wl_up() returned %d\n", __func__, err);
> +		wiphy_err(hw->wiphy, "%s: wl_up() returned %d\n", __func__,
> +			  err);

Is emitting __func__ really useful?
I don't think so.


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux