On Tue, Oct 20, 2020 at 08:11:11AM -0700, Elena Afanasova wrote: > Reported by checkpatch.pl. The commit message should be considered like an separate thing from the subject. On my email client, I normally read either just the subject or just the commit message. It looks something like this: https://lore.kernel.org/driverdev-devel/20201020151748.35937-1-eafanasova@xxxxxxxxx/T/#t Do you see the subject? It's far away from the commit message. Here is how I would write this commit message: Subject: [PATCH] Staging: rtl8192u: split up long lines Checkpatch complains that these lines are over 100 characters so let's split them up. Some people care about verb tenses or whatever but most maintainers don't. I don't. I only care about if I can basically see what you are changing and why. This patch doesn't affect runtime, but if it did, then I would like some comments about what the bug looks like to the user. Basically if I can understand the commit message then it's fine, and obviously "Reported by checkpatch.pl" is not sufficient to understand what's going on. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
