Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/izabela-bakollari-gmail-com/staging-rtl8723bs-Replace-the-comparision-method/20201027-061116 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9ab476ba001ead1f64430a3a61c9466ac0fa91ed config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1be7587c45233c40c20f755e8da6867c36dde9ca git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review izabela-bakollari-gmail-com/staging-rtl8723bs-Replace-the-comparision-method/20201027-061116 git checkout 1be7587c45233c40c20f755e8da6867c36dde9ca # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from drivers/staging/rtl8723bs/include/drv_types.h:25, from drivers/staging/rtl8723bs/core/rtw_ap.c:9: drivers/staging/rtl8723bs/include/ieee80211.h:745:1: warning: alignment 1 of 'struct ieee80211_assoc_request_frame' is less than 2 [-Wpacked-not-aligned] 745 | } __attribute__ ((packed)); | ^ drivers/staging/rtl8723bs/include/ieee80211.h:752:1: warning: alignment 1 of 'struct ieee80211_assoc_response_frame' is less than 2 [-Wpacked-not-aligned] 752 | } __attribute__ ((packed)); | ^ drivers/staging/rtl8723bs/core/rtw_ap.c: In function 'rtw_ap_set_pairwise_key': >> drivers/staging/rtl8723bs/core/rtw_ap.c:1457:5: error: expected '(' before '!' token 1457 | if !(psetstakey_para) { | ^ | ( drivers/staging/rtl8723bs/core/rtw_ap.c:1457:5: warning: statement with no effect [-Wunused-value] 1457 | if !(psetstakey_para) { | ^~~~~~~~~~~~~~~~~~ In file included from drivers/staging/rtl8723bs/include/drv_types.h:42, from drivers/staging/rtl8723bs/core/rtw_ap.c:9: At top level: drivers/staging/rtl8723bs/include/rtw_security.h:371:28: warning: 'K' defined but not used [-Wunused-const-variable=] 371 | static const unsigned long K[64] = { | ^ vim +1457 drivers/staging/rtl8723bs/core/rtw_ap.c 1442 1443 u8 rtw_ap_set_pairwise_key(struct adapter *padapter, struct sta_info *psta) 1444 { 1445 struct cmd_obj *ph2c; 1446 struct set_stakey_parm *psetstakey_para; 1447 struct cmd_priv *pcmdpriv = &padapter->cmdpriv; 1448 u8 res = _SUCCESS; 1449 1450 ph2c = rtw_zmalloc(sizeof(struct cmd_obj)); 1451 if (!ph2c) { 1452 res = _FAIL; 1453 goto exit; 1454 } 1455 1456 psetstakey_para = rtw_zmalloc(sizeof(struct set_stakey_parm)); > 1457 if !(psetstakey_para) { 1458 kfree(ph2c); 1459 res = _FAIL; 1460 goto exit; 1461 } 1462 1463 init_h2fwcmd_w_parm_no_rsp(ph2c, psetstakey_para, _SetStaKey_CMD_); 1464 1465 psetstakey_para->algorithm = (u8)psta->dot118021XPrivacy; 1466 1467 memcpy(psetstakey_para->addr, psta->hwaddr, ETH_ALEN); 1468 1469 memcpy(psetstakey_para->key, &psta->dot118021x_UncstKey, 16); 1470 1471 res = rtw_enqueue_cmd(pcmdpriv, ph2c); 1472 1473 exit: 1474 1475 return res; 1476 } 1477 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
