On Thu, Oct 22, 2020 at 07:29:31AM +0200, Greg KH wrote: > On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote: > > Hello, > > I am reviewing the file: drivers/staging/greybus/audio_manager_module.c > > and have found that there are several gb_audio_module_*_show functions > > that accept "struct gb_audio_manager_module_attribute * " as a function > > parameter. However, this parameter is not used and should not be > > necessary. Would you suggest cleaning up such functions. > > Try removing it and see why it is really needed to be there :) Thank you Greg. I tried that and realised that the internal show function signature definition will mismatch. It will not be a straight forward change for the clean up sake. I got my answer. Thanks again. Deepak. > > good luck! > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
