On Wed, 21 Oct 2020, Deepak R Varma wrote: > Replace bit masking by BIT macro. This resolves checkpatch issue Replace bit masking by the BIT macro. This resolves the checkpatch issue > "CHECK: Prefer using the BIT macro" > > Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx> > --- > drivers/staging/kpc2000/kpc2000/dma_common_defs.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/kpc2000/kpc2000/dma_common_defs.h b/drivers/staging/kpc2000/kpc2000/dma_common_defs.h > index 8bc78be3c259..613c4898f65e 100644 > --- a/drivers/staging/kpc2000/kpc2000/dma_common_defs.h > +++ b/drivers/staging/kpc2000/kpc2000/dma_common_defs.h > @@ -8,13 +8,13 @@ > #define KPC_DMA_ENGINE_SIZE 0x0100 > #define ENGINE_CAP_PRESENT_MASK 0x1 > > -#define KPC_DMA_CARD_IRQ_ENABLE (1 << 0) > -#define KPC_DMA_CARD_IRQ_ACTIVE (1 << 1) > -#define KPC_DMA_CARD_IRQ_PENDING (1 << 2) > -#define KPC_DMA_CARD_IRQ_MSI (1 << 3) > -#define KPC_DMA_CARD_USER_INTERRUPT_MODE (1 << 4) > -#define KPC_DMA_CARD_USER_INTERRUPT_ACTIVE (1 << 5) > -#define KPC_DMA_CARD_IRQ_MSIX_MODE (1 << 6) > +#define KPC_DMA_CARD_IRQ_ENABLE BIT(0) > +#define KPC_DMA_CARD_IRQ_ACTIVE BIT(1) > +#define KPC_DMA_CARD_IRQ_PENDING BIT(2) > +#define KPC_DMA_CARD_IRQ_MSI BIT(3) > +#define KPC_DMA_CARD_USER_INTERRUPT_MODE BIT(4) > +#define KPC_DMA_CARD_USER_INTERRUPT_ACTIVE BIT(5) > +#define KPC_DMA_CARD_IRQ_MSIX_MODE BIT(6) > #define KPC_DMA_CARD_MAX_PAYLOAD_SIZE_MASK 0x0700 > #define KPC_DMA_CARD_MAX_READ_REQUEST_SIZE_MASK 0x7000 > #define KPC_DMA_CARD_S2C_INTERRUPT_STATUS_MASK 0x00FF0000 > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/06567509e751655184f4f6aed7570c963b608797.1603248985.git.mh12gx2825%40gmail.com. > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel