On 17/09/2020 11:15, Dan Carpenter wrote: > On Thu, Sep 17, 2020 at 10:47:50AM +0100, Dan Scally wrote: >> Hi Greg - thanks for the comments, appreciate it (sorry there's so many, >> I'm new to both C and kernel work) > It's pretty impressive work if you're new to C... Thanks (and for your other reply too, haven't had time to go through it in depth yet). I've been using python for a while, but this is my first attempt at anything serious with C. >>>> + return; >>> No error value? >> The prototype for sync_state callbacks is to return void, so my >> understanding is it can't return an error value. I guess a better thing >> to do might be call another function performing cleanup and unloading >> the driver before the return or something along those lines though. > Yeah. I suspect you should be using a different callback instead of > ->sync_state() but I don't know what... :/ Yeah, this is why I wanted to submit it now really; I too suspect I should really be using a different callback but I couldn't find a better option. > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
