On Wed, Sep 02, 2020 at 03:25:59PM +0200, Antoni Przybylik wrote: > This approach is more elegant and prevents some problems related to > macros such as operator precedence in expanded expression. > ------------------------------------------------------------------- > Changed return type to bool and removed inline sepcifier. > > Signed-off-by: Antoni Przybylik <antoni.przybylik@xxxxx> > --- ^^^ See this line. No that doesn't work at all. Try applying your patch and reviewing the git log. Look the the email archive to see how to send a v2 patch. 1) subject says [PATCH v2] 2) comments under the --- line > drivers/staging/gdm724x/gdm_tty.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel