Fwd: Re: [PATCH] staging: gdm724x: gdm_tty: corrected macro by adding brackets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01.09.2020 13:08, Greg KH wrote:
On Tue, Sep 01, 2020 at 12:43:11PM +0200, antoniprzybylik wrote:
Such macros are dangerous. Consider following example:
	#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
	GDM_TTY_READY(a + b)
This macro will be expanded in such a way:
	(a + b && a + b->tty_dev && a + b->port.count)
And it will lead to errors.
This is for a pointer, no one would ever do that :)

Nobody adds a pointer to a pointer, but it's common to add to it some value like that:

GDM_TTY_READY(myptr + 0x1000)

But, if you really worry about this, turn it into an inline function,
that way you get the proper typedef safety, which is what something like
this should really be, not a macro.

How to do it? Do I need to send another patch?

Antoni Przybylik

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux