Re: [PATCH 2/3] linux-firmware: Removed codeversion from brcm firmware filenames.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/05/2011 08:34 AM, Larry Finger wrote:
I also endorse removing the version number from the firmware name; however, I
see a fundamental flaw in the present submission. Both brcmsmac and its
predecessor brcm80211 have been included in mainline and compat-wireless, have
been widely distributed, and have a number of users. This change will break the
system of every one of them - including mine.

Hmm. Sounds like you've got the firmware installed with it's original name, and are using symlinks. Is that correct? A lot of installations (including at least one major distro) rename the files, and skip the whole symlink approach.

That's we decided to dump the version number appendage. However, if there are a mix of installation approaches, we should take a somewhat different approach on the fix.

> My proposed solution is to do the
rename as done in this patch, but also include links to the new name from every
name used in any distributed version.

The brcm80211/brcmsmac driver has always looked for "brcm/bcm43xx-0.fw". It never looked for the version info on the filename. So I don't quite understand what you mean by "from every name used in any distributed version", as the only name used in all distributed versions of the driver is exactly the name we're trying to give to the firmware file. Could you clarify?

Thanks,
- Henry

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux