Re: [PATCH 1/2] staging: brcm80211: replaced static ASSERTs with BUILD_BUG_ON

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 24, 2011 at 03:44:29PM +0100, Roland Vossen wrote:
> Code cleanup. ASSERTs that check static (compile time) conditions
> have been replaced by the Linux macro BUILD_BUG_ON, so violations
> are detected compile time rather than run time.

I don't see how any of these would ever trigger, so why have them at
all?  Please just remove them.  If they aren't true by now, something's
really wrong with this driver.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux