On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote: > Cleaning up messy multiline function declarations in hal_phy_cfg.h > > This patch is a continuation of patch "Clean up function declarations" This should be merged with that patch, no reason to make it separate. > > Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@xxxxxxxxx> > --- > .../staging/rtl8723bs/include/hal_phy_cfg.h | 56 ++++++------------- > 1 file changed, 16 insertions(+), 40 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > index 3cec06e9f359..2b059c9c7851 100644 > --- a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > +++ b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > @@ -46,49 +46,25 @@ s32 PHY_MACConfig8723B(struct adapter *padapter); > void PHY_SetTxPowerIndex(struct adapter *Adapter, u32 PowerIndex, > u8 RFPath, u8 Rate); > > -u8 > -PHY_GetTxPowerIndex( > -struct adapter *padapter, > -u8 RFPath, > -u8 Rate, > -enum CHANNEL_WIDTH BandWidth, > -u8 Channel > - ); > - > -void > -PHY_GetTxPowerLevel8723B( > -struct adapter *Adapter, > - s32 *powerlevel > - ); > - > -void > -PHY_SetTxPowerLevel8723B( > -struct adapter *Adapter, > -u8 channel > - ); > - > -void > -PHY_SetBWMode8723B( > -struct adapter *Adapter, > -enum CHANNEL_WIDTH Bandwidth, /* 20M or 40M */ > -unsigned char Offset /* Upper, Lower, or Don't care */ > -); > +u8 PHY_GetTxPowerIndex(struct adapter *padapter, u8 RFPath, u8 Rate, > + enum CHANNEL_WIDTH BandWidth, u8 Channel); > + > +void PHY_GetTxPowerLevel8723B(struct adapter *Adapter, s32 *powerlevel); > + > +void PHY_SetTxPowerLevel8723B(struct adapter *Adapter, u8 channel); > > -void > -PHY_SwChnl8723B(/* Call after initialization */ > -struct adapter *Adapter, > -u8 channel > - ); > - > -void > -PHY_SetSwChnlBWMode8723B( > -struct adapter *Adapter, > -u8 channel, > -enum CHANNEL_WIDTH Bandwidth, > -u8 Offset40, > -u8 Offset80 > +void PHY_SetBWMode8723B(struct adapter *Adapter, > + enum CHANNEL_WIDTH Bandwidth, /* 20M or 40M */ > + unsigned char Offset /* Upper, Lower, or Don't care */ Those comments should go at the top of the function declaration, in kernel doc format. thanks greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
