On 26/07/20 3:12 pm, Mauro Carvalho Chehab wrote:
> Em Sun, 26 Jul 2020 14:35:12 +0530
> Rohit K Bharadwaj <bharadwaj.rohit8@xxxxxxxxx> escreveu:
>
>> this patch fixes style of open brace after functions and if statements
>>
>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@xxxxxxxxx>
>
>> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi,
>> blob = (const unsigned char *)fw + bi->blob.offset;
>>
>> /* sanity check */
>> - if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + bi->blob.data_size + bi->blob.padding_size)
>> - {
>> + if (bi->blob.size !=
>> + bi->blob.text_size + bi->blob.icache_size +
>> + bi->blob.data_size + bi->blob.padding_size) {
>
>
> Please adjust the alignments here. I'm pretty sure checkpatch --strict
> will end complaining with the above, as the first line ends with "=".
>
> I would, instead, code it as:
>
> if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size +
> bi->blob.data_size + bi->blob.padding_size) {
>
>
> Thanks,
> Mauro
>
sure sir, do I have to make a v4 of the patch and send all the patches in this series again or should I just send this one particular patch again?
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
