On Sat, 2020-07-25 at 12:47 -0500, Larry Finger wrote:
> On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
> > Running the checkpatch.pl script on the file for which patch was created, the
> > following error was found to exist.
> > ERROR: space required after that ',' (ctx:VxV)
> >
> > Fixed the above error which was found on line #721 by inserting a blank
> > space at the appropriate position.
[]
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
[]
> > @@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
> > res = _FAIL;
> > }
> > } else {
> > - RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
> > + RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
> > res = _FAIL;
> > }
> > }
>
> In fixing one checkpatch.pl condition, you introduced another - the resulting
> line is too long. You should fix only one such condition, but you should fix any
> others that are introduced. You do need to document it.
I think that doesn't matter as it was also too long
before this change.
> Patch subjects for this driver should be written as "staging: rtl8188eu: .....".
How likely is it that this driver would ever be
moved to drivers/net/wireless/realtek/rtlwifi?
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
