On Wed, Jul 22, 2020 at 08:32:54AM +0200, Greg KH wrote: > On Wed, Jul 22, 2020 at 11:57:11AM +0530, Rahul Gottipati wrote: > > On Tue, Jul 21, 2020 at 08:05:33PM +0200, Greg KH wrote: > > > On Tue, Jul 21, 2020 at 11:32:03PM +0530, Rahul Gottipati wrote: > > > > This adds a module parameter to get the program bus width as an > > > > input rather than hardcoding it, and checks off a TODO item. > > > > > > Ick, no, module parameters are from the 1990's, please make this dynamic > > > somehow. > > > > Hi, I'm pretty new to this. Do you have any ideas/suggestions on how to > > do this dynamically? > > It all depends on what the paramater is, what it is needed for, and who > would ever need to change it. > > So I think it would take a bit of domain-specific knowledge here to > determine that, it's not a general "code cleanup" task. Thanks for the response. So, just to clarify, this task isn't appropriate for beginners who are not intimately involved with this project right? > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel