Re: [PATCH v3] staging: kpc2000: Replace depracated MSI APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 19, 2020 at 07:42:22PM +0530, Suraj Upadhyay wrote:
> Replace depracated MSI IRQ enabler and disabler
> with pci_alloc_irq_vectors and pci_free_irq_vectors respectively.
> Compile tested.
> 
> Signed-off-by: Suraj Upadhyay <usuraj35@xxxxxxxxx>
> ---
> Changes:
> 	v3: Replaced the disabler for MSI IRQ too with
>             pci_free_irq_vectors.

No, this still has bugs.  Grep the file for msi and update everything
and update the comments and label names as well.

Can you just slow down a bit and fix one driver correctly before trying
to fix a bunch of drivers?

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux