On Thu, Jul 16, 2020 at 10:28:06AM -0400, B K Karthik wrote: > On Thu, Jul 16, 2020 at 10:25 AM Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Thu, Jul 16, 2020 at 10:17:47AM -0400, B K Karthik wrote: > > > fixed sparse warnings by adding a cast in assignment from > > > void [noderef] __user * to unsigned int __force * > > > and a reverse cast in argument from > > > unsigned int * to unsigned int __user * . > > > > > > Signed-off-by: B K Karthik <karthik.bk2000@xxxxxxxx> > > > --- > > > drivers/staging/comedi/comedi_fops.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > What changed from previous versions? > > As Ian Abbott said "Minor quibble: the reverse cast is actually from > unsigned int * to" > > Hence this is a change in the commit description. How was anyone supposed to know this? :) > > That always goes below the --- line. > > I did not understand this sir, can you please clarify? Please read the documentation for how to properly version patches, it's in the submitting patches document. Do that and send a v4 for this. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
