On Mon, Jul 13, 2020 at 05:52:22PM +0530, Suraj Upadhyay wrote: > Use direct assignment instead of using memset with just one byte as an > argument. > Issue found by checkpatch.pl. > > Signed-off-by: Suraj Upadhyay <usuraj35@xxxxxxxxx> > --- > Hii Maintainers, > Please correct me if I am wrong here. > --- > > drivers/staging/qlge/qlge_ethtool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c > index 16fcdefa9687..d44b2dae9213 100644 > --- a/drivers/staging/qlge/qlge_ethtool.c > +++ b/drivers/staging/qlge/qlge_ethtool.c > @@ -516,8 +516,8 @@ static void ql_create_lb_frame(struct sk_buff *skb, > memset(skb->data, 0xFF, frame_size); > frame_size &= ~1; > memset(&skb->data[frame_size / 2], 0xAA, frame_size / 2 - 1); > - memset(&skb->data[frame_size / 2 + 10], 0xBE, 1); > - memset(&skb->data[frame_size / 2 + 12], 0xAF, 1); > + skb->data[frame_size / 2 + 10] = (unsigned char)0xBE; > + skb->data[frame_size / 2 + 12] = (unsigned char)0xAF; Remove the casting. I guess this is better than the original because now it looks like ql_check_lb_frame(). It's still really weird looking though. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
