use kernel crc functionality (?)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I had a quick look at the slicoss driver in the staging directory and was 
wondering if anything speaks against using the crc32 functionality provided by 
the kernel instead of reimplementing it.

The slic_mcast_init_crc32 function looks quite a bit similar to the 
crc32init_le function in the kernel and e equals CRCPOLY_LE after the for 
loop. 
(btw the comment is missing x^0)


-> So can't we use ether_crc from include/linux/crc32.h instead of calculation 
the mac hash by ourselves? Or am I missing something?
(not sure whether ether_crc or ether_crc_le is the correct one)



Thanks,
Peter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux