On Tuesday 23 June 2020 11:00:04 Ajay.Kathat@xxxxxxxxxxxxx wrote: > This patch series is to review and move wilc1000 driver out of staging. > Most of the review comments received in [1] & [2] are addressed in the > latest code. > Please review and provide your inputs. Hello Ajay! Could you please move SDIO vendor/device ID definitions from driver code wilc1000/sdio.c to common file include/linux/mmc/sdio_ids.h? Similar cleanup was recently finished for all existing non-staging drivers: https://lore.kernel.org/linux-mmc/20200522144412.19712-1-pali@xxxxxxxxxx/ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel