On Sun, Jun 28, 2020 at 12:43:02PM +0200, Greg KH wrote:
> On Sun, Jun 28, 2020 at 10:52:36AM +0200, Linus Walleij wrote:
> > The code has the functionality to insert the GPIO lines using
> > the global GPIO numbers through module parameters.
> >
> > As we are clearly deprecating the use of global GPIO numbers
> > look up the GPIO descriptors from the device instead. This
> > usually falls back to device hardware descriptions using e.g.
> > device tree or ACPI. This device clearly supports device
> > tree when used over SPI for example.
> >
> > For example, this can be supplied in the device tree like so:
> >
> > wfx@0x01 {
> > compatible = "silabs,wf200";
> > reset-gpios = <&gpio0 1>;
> > wakeup-gpios = <&gpio0 2>;
> > };
> >
> > Cc: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > ---
> > ChangeLog v2->v3:
> > - ERR_CAST not PTR_CAST
> > ChangeLog v1->v2:
> > - Fixed a cast and a variable name.
> > - I still don't know how to compile this but hey the zeroday
> > robot does.
>
> I can build this on my desktop, and this patch still blows up the build.
Oh, and here's the breakage:
rivers/staging/wfx/bus_spi.c: In function ‘wfx_spi_probe’:
drivers/staging/wfx/bus_spi.c:209:63: error: expected ‘)’ before ‘GPIOD_OUT_HIGH’
209 | bus->gpio_reset = devm_gpiod_get_optional(&func->dev, "reset"
| ^
| )
210 | GPIOD_OUT_HIGH);
| ~~~~~~~~~~~~~~
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
