On Fri, Jun 26, 2020 at 05:06:33PM -0700, Joe Perches wrote:
On Sat, 2020-06-27 at 07:57 +0800, Coiby Xu wrote:
On Thu, Jun 25, 2020 at 03:13:14PM -0700, Joe Perches wrote:
> On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote:
> > Remove unnecessary elses after return or break.
>
> unrelated trivia:
[]
> looks like all of these could use netdev_err
[]
should we also replace all pr_errs with netdev_err in
ql_dump_* functions?
Ideally, anywhere a struct netdevice * is available, it should
be used to output netdev_<level> in preference to pr_<level>.
Thank you for the explaining!
--
Best regards,
Coiby
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
