On Sun, Jun 14, 2020 at 02:51:25PM +0100, Ricardo Ferreira wrote: > #define init_h2fwcmd_w_parm_no_rsp(pcmd, pparm, code) \ > do {\ > - INIT_LIST_HEAD(&pcmd->list);\ > - pcmd->cmdcode = code;\ > - pcmd->parmbuf = (u8 *)(pparm);\ > - pcmd->cmdsz = sizeof(*pparm);\ > - pcmd->rsp = NULL;\ > - pcmd->rspsz = 0;\ > + INIT_LIST_HEAD(&(pcmd)->list);\ > + (pcmd)->cmdcode = code;\ > + (pcmd)->parmbuf = (u8 *)((pparm));\ > + (pcmd)->cmdsz = sizeof(*(pparm));\ > + (pcmd)->rsp = NULL;\ > + (pcmd)->rspsz = 0;\ > } while (0) Does that change really make any sense? checkpatch is a nice hint, sometimes it is not correct... _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel