Re: [PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Anyway, can you resend with the commit message re-written.  To me the
information that's most useful is from the lwn article:

   "In short, if pages are being pinned for access to the data
    contained within those pages, pin_user_pages() should be used. For
    cases where the intent is to manipulate the page structures
    corresponding to the pages rather than the data within them,
    get_user_pages() is the correct interface."

What are the runtime implications of this patch?  I'm still not clear on
that honestly.

When I'm reviewing patches, I also want to know how a bug was
introduced.  In this case the original author did everything correctly
but we've just added some new features (cleanups.  whatever).

I did skim the LWN article back in December but I don't remember the
details so I really want all this stuff re-stated in each commit
message.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux