Re: [PATCH] media: atomisp: get rid of a warning message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Tue, 26 May 2020 12:54:18 +0300
Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu:

> On Tue, May 26, 2020 at 10:53:57AM +0200, Mauro Carvalho Chehab wrote:
> > There's a warning message about an unused code. The code that
> > were using it were commented out, due to a problem causing the
> > firmware load to fail on the machines we're using for testing.
> > 
> > Change the place where we're commenting the code out, in order
> > to avoid the warning.
> > 
> > Fixes: 95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it")
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>  
> 
> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> 
> Note that some of this may be needed to power on some parts of the
> hardware on some platforms.

Yes, I know. That's why I'm preserving the code over there.

This driver is supposed to work on 4 different types of Atom CPU:


	#define __IS_SOC(x) (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && \
			     boot_cpu_data.x86 == 6 &&                       \
			     boot_cpu_data.x86_model == x)


	#define IS_MFLD	__IS_SOC(0x27)
	#define IS_BYT		__IS_SOC(0x37)
	#define IS_CHT		__IS_SOC(0x4C)
	#define IS_MOFD	__IS_SOC(0x5A)


Right now, I have just the CHT hardware for testing.

Thanks,
Mauro
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux