On Mon, 28 Mar 2011 10:29:20 +0800 Lu Guanqun <guanqun.lu@xxxxxxxxx> wrote: > This patch originates from Jeff Cheng's patch to enable the internal > speaker. > > On Moorestown platform, internal speaker's power line is connected to > a GPIO line, this information is got from SFI GPIO table, so we need > set it to 1 to enable the internal speaker, or set it to 0 to disable > it. > > When we set the output device, we power on or off the internal > speaker on demand. This one looks fine to me - just need to figure out the right way to get the GPIO pin. Really for a PCI device it ought to be coming from the PCI space. I will talk to Arjan and co about it. Alan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel