Re: [PATCH V1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vaibhav,

I love your patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.7-rc5 next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Vaibhav-Agarwal/Enable-Greybus-Audio-codec-driver/20200518-012023
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git cef077e6aa4c7dbe2f23e1201cf705f9540ec467
config: i386-allyesconfig (attached as .config)
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-193-gb8fad4bc-dirty
        # save the attached .config to linux build tree
        make C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)

>> drivers/staging/greybus/audio_codec.c:691:36: sparse: sparse: incorrect type in initializer (different base types) @@    expected unsigned long long [usertype] formats @@    got restricteunsigned long long [usertype] formats @@
>> drivers/staging/greybus/audio_codec.c:691:36: sparse:    expected unsigned long long [usertype] formats
>> drivers/staging/greybus/audio_codec.c:691:36: sparse:    got restricted snd_pcm_format_t [usertype]
   drivers/staging/greybus/audio_codec.c:701:36: sparse: sparse: incorrect type in initializer (different base types) @@    expected unsigned long long [usertype] formats @@    got restricteunsigned long long [usertype] formats @@
   drivers/staging/greybus/audio_codec.c:701:36: sparse:    expected unsigned long long [usertype] formats
   drivers/staging/greybus/audio_codec.c:701:36: sparse:    got restricted snd_pcm_format_t [usertype]
--
>> drivers/staging/greybus/audio_module.c:223:25: sparse: sparse: incorrect type in assignment (different base types) @@    expected restricted __le16 [usertype] data_cport @@    got tricted __le16 [usertype] data_cport @@
>> drivers/staging/greybus/audio_module.c:223:25: sparse:    expected restricted __le16 [usertype] data_cport
>> drivers/staging/greybus/audio_module.c:223:25: sparse:    got unsigned short [usertype] intf_cport_id
--
>> drivers/staging/greybus/audio_topology.c:183:24: sparse: sparse: cast to restricted snd_ctl_elem_type_t
>> drivers/staging/greybus/audio_topology.c:460:40: sparse: sparse: restricted __le32 degrades to integer
>> drivers/staging/greybus/audio_topology.c:691:41: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int access @@    got restricted __le3unsigned int access @@
>> drivers/staging/greybus/audio_topology.c:691:41: sparse:    expected unsigned int access
>> drivers/staging/greybus/audio_topology.c:691:41: sparse:    got restricted __le32 [usertype] access
>> drivers/staging/greybus/audio_topology.c:678:14: sparse: sparse: restricted snd_ctl_elem_iface_t degrades to integer
>> drivers/staging/greybus/audio_topology.c:746:44: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int @@    got restrunsigned int @@
>> drivers/staging/greybus/audio_topology.c:746:44: sparse:    expected unsigned int
>> drivers/staging/greybus/audio_topology.c:746:44: sparse:    got restricted __le32
   drivers/staging/greybus/audio_topology.c:748:52: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int @@    got restrunsigned int @@
   drivers/staging/greybus/audio_topology.c:748:52: sparse:    expected unsigned int
   drivers/staging/greybus/audio_topology.c:748:52: sparse:    got restricted __le32
   drivers/staging/greybus/audio_topology.c:803:42: sparse: sparse: restricted __le32 degrades to integer
>> drivers/staging/greybus/audio_topology.c:806:50: sparse: sparse: incorrect type in assignment (different base types) @@    expected restricted __le32 @@    got icted __le32 @@
>> drivers/staging/greybus/audio_topology.c:806:50: sparse:    expected restricted __le32
>> drivers/staging/greybus/audio_topology.c:806:50: sparse:    got unsigned int
   drivers/staging/greybus/audio_topology.c:815:50: sparse: sparse: restricted __le32 degrades to integer
   drivers/staging/greybus/audio_topology.c:818:58: sparse: sparse: incorrect type in assignment (different base types) @@    expected restricted __le32 @@    got icted __le32 @@
   drivers/staging/greybus/audio_topology.c:818:58: sparse:    expected restricted __le32
   drivers/staging/greybus/audio_topology.c:818:58: sparse:    got unsigned int
   drivers/staging/greybus/audio_topology.c:890:25: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int access @@    got restricted __le3unsigned int access @@
   drivers/staging/greybus/audio_topology.c:890:25: sparse:    expected unsigned int access
   drivers/staging/greybus/audio_topology.c:890:25: sparse:    got restricted __le32 [usertype] access
   drivers/staging/greybus/audio_topology.c:906:14: sparse: sparse: restricted snd_ctl_elem_iface_t degrades to integer

vim +691 drivers/staging/greybus/audio_codec.c

d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23  683  
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  684  static struct snd_soc_dai_driver gbaudio_dai[] = {
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  685  	{
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  686  		.name = "apb-i2s0",
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  687  		.id = 0,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  688  		.playback = {
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  689  			.stream_name = "I2S 0 Playback",
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  690  			.rates = SNDRV_PCM_RATE_48000,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 @691  			.formats = SNDRV_PCM_FORMAT_S16_LE,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  692  			.rate_max = 48000,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  693  			.rate_min = 48000,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  694  			.channels_min = 1,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  695  			.channels_max = 2,
1023ab9c3800e58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2017-01-18  696  			.sig_bits = 16,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  697  		},
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  698  		.capture = {
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  699  			.stream_name = "I2S 0 Capture",
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  700  			.rates = SNDRV_PCM_RATE_48000,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  701  			.formats = SNDRV_PCM_FORMAT_S16_LE,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  702  			.rate_max = 48000,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  703  			.rate_min = 48000,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  704  			.channels_min = 1,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  705  			.channels_max = 2,
1023ab9c3800e58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2017-01-18  706  			.sig_bits = 16,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  707  		},
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  708  		.ops = &gbcodec_dai_ops,
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  709  	},
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  710  };
19866603be2ad58 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04  711  

:::::: The code at line 691 was first introduced by commit
:::::: 19866603be2ad58735f82511f3d5f680e61479ea greybus: audio: Maintain runtime stream params for each DAI

:::::: TO: Vaibhav Agarwal <vaibhav.agarwal@xxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux