On Sun, 17 May 2020 at 17:58, Pascal Terjan <pterjan@xxxxxxxxxx> wrote: > > This causes a change in behaviour: > - stats also get updated when reordering, this seems like it should be > the case but those lines were commented out. > - sub_skb NULL check now happens early in both cases, previously it > happened only after dereferencing it 12 times, so it may not actually > be needed. > Hi, I actually noticed the same duplicated code (and same late NULL check) in drivers/staging/rtl8192e/rtllib_rx.c drivers/staging/rtl8712/rtl8712_recv.c has only one copy of the code but with the late NULL check drivers/staging/rtl8188eu/core/rtw_recv.c has only one copy of the code and doesn't do any NULL check Now I wonder how to proceed. The code is not great so it would not feel right to make it reusable. Should I continue improving it on this driver only first (maybe trying to reuse ieee80211_data_to_8023_exthdr from net/wireless/util.c for example)? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
