On Mon, 2020-05-04 at 17:39 +0200, Greg KH wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Mon, May 04, 2020 at 03:17:53PM +0000, > Christian.Gromm@xxxxxxxxxxxxx wrote: > > On Mon, 2020-05-04 at 15:54 +0200, Greg KH wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > > know the content is safe > > > > > > On Mon, May 04, 2020 at 03:44:00PM +0200, Christian Gromm wrote: > > > > This patch fixes error handling on function parameters. > > > > > > What does that mean? If I don't understand it, I think it needs > > > to > > > be > > > made a lot more explicit as to why you are making these changes > > > :) > > > > > > > Signed-off-by: Christian Gromm <christian.gromm@xxxxxxxxxxxxx> > > > > > > Any "Fixes:" tag for this? > > > > No. Just wanted to fix some obvious things, before adding > > it to stable, as discussed in our last email thread. > > Remember, no one has context when reading a git commit log, please > spell > it out :) > > > > SHould it go to stable if it really resolves issues? > > > > No. Once you accept this, I'll add it to stable anyway. > > How? Put the cc: stable on a patch if it fixes a real bug. I don't > see > what this "fixes" still... The interface pointer provided as a function parameter has already been used before it has been checked against NULL. :( Once I have the unnecessary parameter checking removed, the problem will be removed too. Can you please drop this patch and I'll send a new one. V2 does not make very much sense, as the patch will be doing somethig differnt now. thanks, Chris _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
