Hi Guanqun The msleep is to try disable pop noise. If you have better way to disable pop noise, please fix it. Thanks. -----Original Message----- From: Lu Guanqun [mailto:guanqun.lu@xxxxxxxxx] Sent: Monday, March 28, 2011 10:53 AM To: Arjan van de Ven; Jeff Cheng/WHQ/Wistron Cc: meego-kernel@xxxxxxxxxxxxxxx; alan@xxxxxxxxxxxxxxx; Wu, Fengguang; Tang, Feng; Fu, Michael; Wang, Xingchao; Koul, Vinod; Kp, Jeeja; Greg Kroah-Hartman; Babu, Ramesh; R, Dharageswari; devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line On Mon, Mar 28, 2011 at 10:35:36AM +0800, Arjan van de Ven wrote: > On 3/27/2011 7:29 PM, Lu Guanqun wrote: > > > > pr_debug("sst: powering dn nc_power_down ....\n"); > > > > + if (snd_pmic_ops_nc.output_dev_id == MONO_EARPIECE || > > + snd_pmic_ops_nc.output_dev_id == INTERNAL_SPKR) { > > + msleep(30); > > + nc_set_amp_power(0); > > + } > > msleep(30); > > this double msleep sounds rather harsh... why do we need two of these ? > (heck... why do we need ONE ?) > This is legacy code from Jeff Cheng's patch. Jeff, could you provide some information on this line? -- guanqun _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
