On Thu, Apr 30, 2020 at 10:09:14AM +0000, Christian.Gromm@xxxxxxxxxxxxx wrote: > On Thu, 2020-04-30 at 10:13 +0200, Greg KH wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > On Thu, Apr 30, 2020 at 10:09:31AM +0200, Greg KH wrote: > > > On Thu, Apr 30, 2020 at 10:07:35AM +0200, Greg KH wrote: > > > > On Thu, Apr 30, 2020 at 10:00:12AM +0200, Christian Gromm wrote: > > > > > This patch moves the MOST USB adapter driver to the stable > > > > > branch. > > > > > It is a follow-up to commit <b276527>. > > > > > > > > That's not how to refer to git commit ids. Please see the > > > > submitting-patches.rst file for the proper format. > > > > > > Also, you might want to run this driver by the usb mailing list, > > So I just put linux-usb@xxxxxxxxxxxxxxx on cc? Yes please. > > > I don't > > > think it's been audited by anyone, myself included, for any usb > > > specific > > > things. > > Probably not. > > > > > > > As proof, I see at least one thing that should be changed... > > > > Ok, lots of little things, I don't think I ever actually read this > > driver before, sorry about that... > > > > Please post it as a patch that just adds the file, > > And another patch that removes the one from the staging directory? After we get through everything, and it's all fixed up, then we can worry about removing it from the staging directory. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
