Hi Greg,
Thanks for the cleanup.
On Tue, Apr 28, 2020 at 07:04:05PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Rui Miguel Silva <rmfrfs@xxxxxxxxx>
> Cc: Steve Longerbeam <slongerbeam@xxxxxxxxx>
> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: NXP Linux Team <linux-imx@xxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx
> Cc: devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>
Cheers,
Rui
> ---
> drivers/staging/media/imx/imx7-mipi-csis.c | 29 ++++------------------
> 1 file changed, 5 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
> index fbc1a924652a..d7c9e7343f1f 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -915,33 +915,14 @@ static int mipi_csis_dump_regs_show(struct seq_file *m, void *private)
> }
> DEFINE_SHOW_ATTRIBUTE(mipi_csis_dump_regs);
>
> -static int mipi_csis_debugfs_init(struct csi_state *state)
> +static void mipi_csis_debugfs_init(struct csi_state *state)
> {
> - struct dentry *d;
> -
> - if (!debugfs_initialized())
> - return -ENODEV;
> -
> state->debugfs_root = debugfs_create_dir(dev_name(state->dev), NULL);
> - if (!state->debugfs_root)
> - return -ENOMEM;
> -
> - d = debugfs_create_bool("debug_enable", 0600, state->debugfs_root,
> - &state->debug);
> - if (!d)
> - goto remove_debugfs;
> -
> - d = debugfs_create_file("dump_regs", 0600, state->debugfs_root,
> - state, &mipi_csis_dump_regs_fops);
> - if (!d)
> - goto remove_debugfs;
> -
> - return 0;
> -
> -remove_debugfs:
> - debugfs_remove_recursive(state->debugfs_root);
>
> - return -ENOMEM;
> + debugfs_create_bool("debug_enable", 0600, state->debugfs_root,
> + &state->debug);
> + debugfs_create_file("dump_regs", 0600, state->debugfs_root, state,
> + &mipi_csis_dump_regs_fops);
> }
>
> static void mipi_csis_debugfs_exit(struct csi_state *state)
> --
> 2.26.2
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
