On Mon, 2020-04-27 at 18:04 +0200, Greg KH wrote: > On Mon, Apr 27, 2020 at 04:24:42PM +0100, John Oldman wrote: > > Make a better job of fixing coding style issues, this time fixing > > all blocks as per Joe Perches' comment. [] > Why is this not just one patch? Hi John. These _should_ be one patch. The subject line should be versioned and affirmative like: Subject: [PATCH V2] staging: rts5208: rtsx: Use balanced braces for if/else if blocks The subject should not include "fix", as this is a coding style issue and not really a logical defect. Lastly the "this time fixing" bit should be below the --- line. cheers, Joe _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
