Re: [PATCH] staging: wfx: cleanup long lines in data_tx.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 23, 2020 at 09:29:28AM +0000, Jerome Pouiller wrote:
> >         req->data_flags.fc_offset = offset;
> >         if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM)
> >                 req->data_flags.after_dtim = 1;
> > @@ -517,7 +523,8 @@ void wfx_tx_confirm_cb(struct wfx_vif *wvif, const struct hif_cnf_tx *arg)
> >                 if (tx_count < rate->count &&
> >                     arg->status == HIF_STATUS_RETRY_EXCEEDED &&
> >                     arg->ack_failures)
> > -                       dev_dbg(wvif->wdev->dev, "all retries were not consumed: %d != %d\n",
> > +                       dev_dbg(wvif->wdev->dev,
> > +                               "all retries were not consumed: %d != %d\n",
> 
> Is this reported by checkpatch? The strings can exceed 80 columns.
> 

The string can go over 80 characters, but it's nice to do our best to
avoid it so we do normally break it up like this where the string is
on its own line.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux