On Mon, Apr 13, 2020 at 03:01:29AM +0000, Camylla Goncalves Cantanheide wrote: > Renames the local variables of the setKey > function, making them explicit. Why do this? > > Signed-off-by: Camylla Goncalves Cantanheide <c.cantanheide@xxxxxxxxx> > --- > drivers/staging/rtl8192u/r8192U_core.c | 48 +++++++++++++------------- > 1 file changed, 24 insertions(+), 24 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c > index 87c02aee3854..cc02c3b1eb91 100644 > --- a/drivers/staging/rtl8192u/r8192U_core.c > +++ b/drivers/staging/rtl8192u/r8192U_core.c > @@ -4877,48 +4877,48 @@ void EnableHWSecurityConfig8192(struct net_device *dev) > write_nic_byte(dev, SECR, SECR_value); > } > > -void setKey(struct net_device *dev, u8 entryno, u8 keyindex, u16 keytype, > - u8 *macaddr, u8 defaultkey, u32 *keycontent) > +void setKey(struct net_device *dev, u8 entry_no, u8 key_idx, u16 key_type, > + u8 *mac_addr, u8 default_key, u32 *key_content) What was wrong with the original names? Why add a '_' character for no good reason? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
