Re: [kbuild-all] Re: [staging:staging-testing 41/41] drivers/staging/vt6655/baseband.c:1711:15: warning: The scope of the variable 'preamble' can be reduced. [variableScope]

"Chen, Rong A" <rong.a.chen@xxxxxxxxx> · Sun, 5 Apr 2020 22:51:59 +0800

On 4/5/2020 9:07 PM, Greg Kroah-Hartman wrote:
On Sun, Apr 05, 2020 at 08:43:40PM +0800, kbuild test robot wrote:
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
head:   e7b6875944e61bec586ede80b95727cd55381e1e
commit: e7b6875944e61bec586ede80b95727cd55381e1e [41/41] Staging: vt6655: Replace camel case variable names.

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

cppcheck warnings: (new ones prefixed by >>)

drivers/staging/vt6655/baseband.c:1711:15: warning: The scope of the variable 'preamble' can be reduced. [variableScope]
     unsigned int preamble;
                  ^
drivers/staging/vt6655/baseband.c:1912:16: warning: The scope of the variable 'by_value' can be reduced. [variableScope]
  unsigned char by_value;
                   ^
    drivers/staging/vt6655/baseband.c:1955:16: warning: The scope of the variable 'by_value' can be reduced. [variableScope]
  unsigned char by_value;
                   ^
Are we seriously going to take foolish things like this from cppcheck
seriously?

Please no, "reducing scope" is an interesting thing to consider, but
really, solves almost nothing.  It will do nothing but cause a lot of
pointless churn.

greg k-h

Hi Greg,

Thanks for the advice, we'll blacklist the warning and don't report it.

Best Regards,
Rong Chen
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel