Re: [PATCH v8] staging: vt6656: add error code handling to unused variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/31/20 02:01:03, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 16:39:00 -0700
> "John B. Wyatt IV" <jbwyatt4@xxxxxxxxx> wrote:
> 
> > Add error code handling to unused 'ret' variable that was never used.
> > Return an error code from functions called within vnt_radio_power_on.
> > 
> > Issue reported by coccinelle (coccicheck).
> > 
> > Suggested-by: Quentin Deslandes <quentin.deslandes@xxxxxxxxxxx>
> > Suggested-by: Stefano Brivio <sbrivio@xxxxxxxxxx>
> > Reviewed-by: Quentin Deslandes <quentin.deslandes@xxxxxxxxxxx>
>   ^ This should be dropped unless Quentin agrees to this version as well
> 
> > Signed-off-by: John B. Wyatt IV <jbwyatt4@xxxxxxxxx>
> 
> Reviewed-by: Stefano Brivio <sbrivio@xxxxxxxxxx>
> 
> -- 
> Stefano
> 

Just reviewed it so John doesn't need to send a v9. Everything seems
good, I'm happy and checkpatch is too.

Reviewed-by: Quentin Deslandes <quentin.deslandes@xxxxxxxxxxx>

Thanks,
Quentin
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux