On Mon, 2020-03-30 at 16:46 +0100, Quentin Deslandes wrote: > On 03/29/20 01:43:20, John B. Wyatt IV wrote: > > Add error code handling to unused 'ret' variable that was never > > used. > > Return an error code from functions called within > > vnt_radio_power_on. > > > > Issue reported by coccinelle (coccicheck). > > > > Suggested-by: Quentin Deslandes <quentin.deslandes@xxxxxxxxxxx> > > Suggested-by: Stefano Brivio <sbrivio@xxxxxxxxxx> > > Signed-off-by: John B. Wyatt IV <jbwyatt4@xxxxxxxxx> > > --- > > v3: Forgot to add v2 code changes to commit. > > > > v2: Replace goto statements with return. > > Remove last if check because it was unneeded. > > Suggested-by: Julia Lawall <julia.lawall@xxxxxxxx> > > Because it's after the comment line (---), this Suggested-by tag will > be > stripped-off when applying the patch. Understood. > If you could fix it, then add my review tag. > > Reviewed-by: Quentin Deslandes <quentin.deslandes@xxxxxxxxxxx> > > Thanks, > Quentin Done. Please see v4. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
