On Sun, Mar 22, 2020 at 02:23:03AM -0700, John B. Wyatt IV wrote: > Remove unneeded variable ret; replace with 0 for the return value. > > Update function documentation (comment) on the return status as > suggested by Julia Lawall <julia.lawall@xxxxxxxx>. > > Issue reported by coccinelle (coccicheck). > > Signed-off-by: John B. Wyatt IV <jbwyatt4@xxxxxxxxx> > --- > drivers/staging/vt6656/card.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c > index dc3ab10eb630..05b57a2489a0 100644 > --- a/drivers/staging/vt6656/card.c > +++ b/drivers/staging/vt6656/card.c > @@ -716,13 +716,11 @@ int vnt_radio_power_off(struct vnt_private *priv) > * Out: > * none > * > - * Return Value: true if success; otherwise false > + * Return Value: 0 If this always returns something, why have it return anything at all? Why not make this a patch series, doing this, and then fixing up the callers and the function to not return anything. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
