+devel,+broadcom On Tue, Mar 22, 2011 at 7:58 PM, Alim Akhtar <alim.akhtar@xxxxxxxxx> wrote: > Hi Grant, > Hope you are doing good. > As Âyou know, i am also using brcm4329 wifi driver. > recently i come across come patches which fix the suspend/resume issue > in brcmfamc driver. Hi Alim, Please keep the devel mailing list CC'd when asking for help with "staging-2.6" drivers. While I'm honored you think I might be able to solve your problem, it's very likely I can't or someone else could solve it sooner. > > http://groups.google.com/a/chromium.org/group/chromium-os-reviews/browse_thread/thread/0fd4596e9af6e2ca > http://codereview.chromium.org/6489022/diff/1/include/linux/mmc/sdhci.h > http://codereview.chromium.org/6489022 > http://codereview.chromium.org/6489022/diff/1/drivers/mmc/host/sdhci.c > > I applied all the above patches to my kernel (based on 2.6.36, as i > can not upgrade now). 1) There should be at least these 4 patches (and possibly more for 2.6.36): http://codereview.chromium.org/6488018 http://codereview.chromium.org/6474032 http://codereview.chromium.org/6489022 http://codereview.chromium.org/6484021 Use "download raw patch set" link provided on each page to pull the patch. 2) I have no idea if/how those patches will apply to 2.6.36 - I expect they should. Additional patches might be required that went into 2.6.37. In other words, for 2.6.36, those 4 CLs I posted from Venkat Rao (Broadcom) might not be enough. 3) You don't mention if and when you've pulled staging-2.6:drivers/staging/brcm80211/ into your 2.6.36 tree. Have you done that already? > When my chrome system goes to suspend, i get below crash: > --------------- > PM: Syncing filesystems ... done. > Freezing user space processes ... (elapsed 0.01 seconds) done. > Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done. > ERROR @wl_dev_intvar_set : error (-22) > ERROR @wl_set_mpc : fail to set mpc > sdioh_sdio_set_host_pm_flags: Failed to set pm_flags 0x00000001 (err=-22) > WARNING: driver brcmfmac did not remove its interrupt handler! > mmc2:0001:1: pending IRQ with no handler > --------------- > any idea on this? Sorry, no idea. I don't see this with chromium.org 2.6.37 kernels. > when i can see you patches to upstream? Here's the current status for the collection of patches I've "adopted" from Broadcom. Issue 6474032: mach-tegra: Adding MMC_KEEP_POWER to support suspend/resume for wifi SDIO slot Not sent upstream yet - need to send different parts to different places. Issue 6488018: brcmfmac: Fix suspend/resume [PATCH] STAGING: brcm80211 v2 keep power on in suspend state http://ns.spinics.net/lists/linux-driver-devel/msg13201.html "V1" http://ns.spinics.net/lists/linux-driver-devel/msg13226.html "V2" I don't see an ACK from gregkh for this one yet. Issue 6484021: brcmfmac: Enabling flow control on uplink data direction I've reworked this completely and gregkh already accepted the reworked patch (remove dhd_doflow) into staging-2.6. Issue 6489022: sdhci:Fix to restore SDIO card interrupt after resume Submitted and reviewed. Two reviewers asked this patch be included but I haven't received an ACK yet that it's accepted. > Did is missed any thing while back porting? My guess is yes. Looks like you only found 2 of the 4 patches that I've posted on behalf of Venkat Rao. cheers, grant > > Regards > Alim > > > On Sat, Feb 5, 2011 at 9:44 PM, Arend van Spriel <arend@xxxxxxxxxxxx> wrote: >> Hi Alim, >> >> On Sat, 05 Feb 2011 10:21:41 +0100, Alim Akhtar <alim.akhtar@xxxxxxxxx> >> wrote: >> >>> Dear Arend Van Spriel >>> >>> I am using BCM4329 chip and downloaded the driver for google chromium git >>> repo (2.6.36 kernel version). >>> I am facing a problem, suspend/resume does not works with this driver. >>> I have seem your commit in the staging tree on 22th Jan "staging: >>> brcm80211: fix suspend/resume in brcmsmac" but i cannt find the fix for >>> brcmfmac. Can you please till suspend/resume for brcmfmac driver is already >>> fixed or it is work in progress? Also if fixed, please till me patch >>> location or send me the patch it self. >> >> The suspend/resume changes for brcmfmac is work in progress at the moment as >> I was told by colleagues working on that driver. I assume the patch will be >> included in the chromium repo and also in the staging repo >> (git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git - >> staging-next branch). >> >> For the staging repo you can keep an eye on the mailing list: >> http://driverdev.linuxdriverproject.org/pipermail/devel/ >> >>> Any help will be appreciated. >>> >>> Regards, >>> Alim >>> >>> >>> -- >>> >> >> Gr. AvS >> -- >> "The most merciful thing in the world, I think, is the inability of the >> human >> mind to correlate all its contents." - "The Call of Cthulhu" >> >> > > > > -- > aLim akHtaR > mAin hUn nA :-) > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
