Hi! On Sat, Mar 21, 2020 at 12:34 AM Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> wrote: > > If I am understanding correctly for example for my gnubee this should > > be as follows: > > > > diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi > > b/drivers/staging/mt7621-dts/mt7621.dtsi > > index 10fb497cf81a..9e5cf68731bb 100644 > > --- a/drivers/staging/mt7621-dts/mt7621.dtsi > > +++ b/drivers/staging/mt7621-dts/mt7621.dtsi > > @@ -538,9 +538,7 @@ pcie: pcie@1e140000 { > > phys = <&pcie0_phy 1>, <&pcie2_phy 0>; > > phy-names = "pcie-phy0", "pcie-phy2"; > > > > - reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>, > > - <&gpio 8 GPIO_ACTIVE_LOW>, > > - <&gpio 7 GPIO_ACTIVE_LOW>; > > + reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>; > > > > pcie@0,0 { > > reg = <0x0000 0 0 0 0>; > > sergio@camaron:~/staging$ git diff drivers/staging/mt7621-dts/gbpc1.dts > > diff --git a/drivers/staging/mt7621-dts/gbpc1.dts > > b/drivers/staging/mt7621-dts/gbpc1.dts > > index 1fb560ff059c..a7c0d3115d72 100644 > > --- a/drivers/staging/mt7621-dts/gbpc1.dts > > +++ b/drivers/staging/mt7621-dts/gbpc1.dts > > @@ -114,6 +114,10 @@ &cpuclock { > > &pcie { > > pinctrl-names = "default"; > > pinctrl-0 = <&pcie_pins>; > > + > > + reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>, > > + <&gpio 8 GPIO_ACTIVE_LOW>, > > + <&gpio 7 GPIO_ACTIVE_LOW>; > > status = "okay"; > > }; > > > > Is this true? So changes will be only in the device tree but driver is > > ok as it is. > > Well, I mean I should only remove the release part for gpios, right? Correct :) -- Regards, Chuanhong Guo _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel