On Wed, Mar 23, 2011 at 02:45:10PM +0800, Xiaochen Wang wrote: > On Tue, Mar 22, 2011 at 09:15:09PM -0700, Greg KH wrote: > > Did you test this change? And it worked? > I'm sorry for not testing this:( > > I can only compile the changed codes in 2.6.35. > The whole msm cannot be compiled in 2.6.38-rc8, in which case I only > compiled the logo.c and msm_fb.c. Why can it not, what is wrong? > There are some removing API, like msm_gpios_request_enable(), > in staging-devices.c and other source files. > And it is beyond my ability to fix these;( Having code that is obviously broken and not building isn't ok. Should I just delete this whole subdirectory then if no one is willing to keep it building properly? > Besides, we cannot add logo.o via Kconfig. > CONFIG_FB_MSM_LOGO is not included in staging/msm/Kconfig. > (I just changed the staging/msm/Makefile to compile the logo.o) > > Last, I found user-space load_565rle_image() in android/system/init/logo.c > Maybe we should not load logo image in kernel space. No, we shouldn't, that is best done in userspace. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
