On Sat, 2020-03-14 at 16:58 +0530, Shreeya Patel wrote: > This could be: > > if ((!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == > > 1)) || > > pregistrypriv->ampdu_enable == 2) > > phtpriv->ampdu_enable = true; > > > > Though it is probably more sensible to just set > > phtpriv->ampdu_enable without testing whether or > > not it's already set: > > > > if (pregistrypriv->ampdu_enable == 1 || > > pregistrypriv->ampdu_enable == 2) > > phtpriv->ampdu_enable = true; > > But the else-if block which I removed in v2 of this patch had nothing > in the block. > It was not assigning any value to "phtpriv->ampdu_enable". ( basically > it was empty and useless) Right, I misread the deletions from patch. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
