The original patch description was basically fine. Outreachy reviews tend to be more pedantic about this sort of stuff than most maintainers. There are a couple who have very strict rules, but try to avoid those maintainers and your life will be happier. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel