On Tue, Mar 22, 2011 at 10:46:05AM +0100, Jiri Slaby wrote: > On 03/18/2011 10:37 AM, Xiaochen Wang wrote: > > Description: > > 1. use filp_open/vfs_read/filp_close instead of system calls > > 2. fix double calling of sys_close when first sys_lseek fails > > 3. reset segment fs when reading file into kernel space buffer > > Hmm, this is still ugly and no driver should do that. This should rather > be converted to request_firmware, right? Yes a driver should never be reading from files on the disk, you are correct. Xiaochen, care to make those fixes instead? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel