On Tue, 2020-03-10 at 15:57 +0100, Julia Lawall wrote: > On Tue, 10 Mar 2020, Shreeya Patel wrote: > > > Add space around operators for improving the code > > readability. > > > > Reported by checkpatch.pl > > > > Signed-off-by: Shreeya Patel <shreeya.patel23498@xxxxxxxxx> > > --- > > > > rtw_mlme_old.o - Previously produced object file before making any > > changes to the source code. > > rtw_mlme.o - Object file produced after compiling the changes done in source > > file. > > > > Following is the output of diff between the previously produced object > > file and the object file produced after compiling the changes. > > > > shreeya@Shreeya-Patel:~git/kernels/staging/drivers/staging/rtl8188eu/core$ diff rtw_mlme_old.o rtw_mlme.o > > shreeya@Shreeya-Patel:~git/kernels/staging/drivers/staging/rtl8188eu/core$ > > > > Following output shows that there was no other change in the source > > code except for whitespace. > > > > shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w drivers/staging/rtl8188eu/core/ > > shreeya@Shreeya-Patel:~git/kernels/staging$ > > If this information is importamt, it should be above the line. On the > other hand, it is much too detailed, making it hard to figure out what is > being said. It would be better to just say diff of the .o files before > and after the changes shows no difference. Likewise git diff -w shows no > difference. That way one can quickly see what tests you did, without > being distracted by the machine name, the directory name, etc. Exactly right. Keep at it Shreeya. Almost done. [It's also nice to trim your replies Julia] _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
