On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > Add space around operators for improving the code > readability. Hello again Shreeya. The subject isn't really quite appropriate as you are not doing this space around operator addition for the entire subsystem. IMO, the subject should be: [PATCH] staging: rtl8188eu: rtw_mlme: Add spaces around operators because you are only performing this change on this single file. If you were to do this for every single file in the subsystem, you could have many individual patches with the exact same subject line. And it would be good to show in the changelog that you have compiled the file pre and post patch without object code change. Also, it's good to show that git diff -w shows no source file changes. > Reported by checkpatch.pl > > Signed-off-by: Shreeya Patel <shreeya.patel23498@xxxxxxxxx> > --- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++++++++++------------ > 1 file changed, 20 insertions(+), 20 deletions(-) When I try this using checkpatch --fix-inplace, I get 21 changes against the latest -next tree. What tree are you doing this against? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
