On Fri, Mar 18, 2011 at 2:44 PM, Dan Carpenter <error27@xxxxxxxxx> wrote:
> On Fri, Mar 18, 2011 at 09:22:02AM -0700, Grant Grundler wrote:
>> On Fri, Mar 18, 2011 at 12:05 AM, Dan Carpenter <error27@xxxxxxxxx> wrote:
>> ...
>> >> Âstatic s32 wl_cfg80211_suspend(struct wiphy *wiphy)
>> >> Â{
>> >> + Â Â void sdioh_sdio_set_host_pm_flags(int flag);
>> >> +
>> >
>> > Let's not put the function declaration here... ÂBetter at the top of the
>> > file with all the others.
>>
>> No problem. I'll resubmit with the declaration at the top (much) later today.
>>
>> Funny thing is Venkat sent the patch that way to me...but this feels
>> like an intermediate step in the development of this driver and I
>> wanted to make the scope of the function as narrow as possible so the
>> next steps are not harder.
>>
>
> Declaring it any place outside the function would be fine.
Done. Just mailed v2 with the declaration at the top.
thanks!
grant
>
> regards,
> dan carpenter
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
