On Tue, Mar 03, 2020 at 05:56:51AM -0800, Joe Perches wrote: > > The real fix is to initialize everything manually, the automated > > initialization is a hardenning feature which many people will disable. > > So I don't think the hardenning needs to be perfect, it needs to simple > > and fast. > > Dan, perhaps I don't understand you. > Can you clarify what you mean? I'm basically agreeing with you. Even though copy_from_user() might only initialize part of the struct we should just record that it initializes the struct without getting bogged down in details. The annotation should be simple. If the automated system to initialize stack variables doesn't work 100% that's okay because it's a supplement and not a replacement for manually initializing stack variables. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
