On Tue, 03 Mar 2020 03:07:51 +0000, "Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx" said: > > Are you sure this is OK to do? exfat_get_entry_type() does a lot of > > mapping between values, using a file_dentry_t->type, while > > fid->type is a file_id_t->type. > The value that vfs sets to the old_dentry of exfat_rename() is the dentry value returned by exfat_lookup(), exfat_create(), and create_dir(). > In each function, the value of dentry->fid is initialized to fid->type at create_file(), ffsLookupFile(), and create_dir(). > > * create_file() <- ffsCreateFile() <-exfat_create() > * ffsLookupFile() <- exfat_find() <-exfat_lookup() > * exfat_mkdir() <- ffsCreateDir() <-create_dir() > > > and at first read it's not obvious to > > me whether type is guaranteed to have the correct value already. > > A valid value is set in fid->type for all paths. > What do you think? OK, that's the part I was worried about, but I hadn't had enough caffeine to do that analysis. Thanks. Acked-by: Valdis Kletnieks <valdis.kletnieks@xxxxxx>
Attachment:
pgpkpjwYHlurp.pgp
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
